For my final release, I didn’t work on as much bugs as I wanted to. I should have claimed more bugs ahead of time, and unfortunately, the bugs that I wanted to work on were already taken. As a result, this release is very small.
The first bug I should mention is something I’m still working on and hope to get it done before the final deadline (April 21st).
Issue #700: https://github.com/mozilla/brackets/issues/700
Pull Request: https://github.com/mozilla/brackets/pull/708
This bug isn’t really a bug. It’s approximately two warnings:
Deprecated: Do not use $().on/off() on Brackets modules and model objects. Call on()/off() directly on the object without a $() wrapper.
main.js:12 Registering for deprecated event 'currentDocumentChange'. Instead, use MainViewManager.currentFileChange.
As you can see, this issues encircles two deprecated events, and it clutters the Developer Console. My initial solution was to remove the first deprecation message in brackets/src/brackets.js:
DeprecationWarning.deprecationWarning(“Deprecated: Do not use $().on/off() on Brackets modules and model objects. Call on()/off() directly on the object without a $() wrapper.“, true, 4);
My next solution was to modify brackets/src/extensions/default/brackets-paste-and-indent/main.js. “currentDocumentChange” was giving the problem. Following brackets/src/document/DocumentManager.js documenation, it suggested I used EditorManager.on(“activeEditorChange” … instead.
These changes got rid of the warnings when I tested it. Unfortunately, when pushing these changes to GitHub, Travis CI didn’t like it.
Later on, I was suggested a different method to solving this issue by @gideonthomas.
Following his steps, I seem to be having an issue with brackets-paste-and-indent submodule. And this is what I’m currently working on.
The second issue I fixed was that of my own.
Pull Request: https://github.com/mozilla/brackets/pull/697
The third issue I fixed was https://github.com/mozilla/thimble.mozilla.org/issues/1962.
When opening the drop-down for the Language menu, it would be cut off if your screen wasn’t tall enough.
My original solution was to give it a max-height property where it’d not pass the green portion of the page and to add a overflow auto property to the public/resources/stylesheets/userbar.less file. The overflow auto property would automatically at a scrollbar if the content within it was clipped in correspondence with the max-height property.
Due to a terrible oversight on my part, I was told by @flukeout that a fixed height wouldn’t be practical as every screen has a different size… He suggested I use the “vh” measurement unit which would give me the height relative to the viewport. He told me to use that in conjunction with the calc() function to let me subtract 85 pixels from 100vh (100% of the viewport). This would make it dynamic and solve the problem.